modmuss comments

Results 504 comments of


                                            modmuss

Fabric API "Breaking" In-Game Profiler

1, seems fine. 2, is this fabric causing it? Or does it happen in vanilla, I'm struggling to think how fabric is causing it?

[DRAFT] Adding transformer support to be able to use remapped dependencies in any configuration.

is this ready for reviews and testing?

[DRAFT] Adding transformer support to be able to use remapped dependencies in any configuration.

No, dont rush or worry at all. I was just checking you werent waiting on me or something stupid 👍

Using Kotlin in mixin config plugins can cause crashes

A real fix for this would be a way to do conditional mixins without needing to use a mixin plugin

Allow mappings to add a message for people to suggest improvements/bugs

Where would the message be displayed? Are you thinking in the logs? Or as a header on the generated sources?

Compile fails when access widener is applied to a constructor which also has an existing invoker.

Uhh, this is an odd one

[Feature Request] An entrypoint loaded before any mixin is applied

Does PreLaunch do what your after? https://github.com/FabricMC/fabric-loader/blob/master/src/main/java/net/fabricmc/loader/api/entrypoint/PreLaunchEntrypoint.java#L20

[Feature Request] An entrypoint loaded before any mixin is applied

Whats your usecase?

[Suggestion] Way to declare injected interfaces elsewhere

I think you can also use single quotes in groovy for string literals

[Suggestion] Way to declare injected interfaces elsewhere

Oh my bad, I read the code snippet totally wrong :D