django-advanced-filters icon indicating copy to clipboard operation
django-advanced-filters copied to clipboard
verified publisher icon modlinltd

Made SimpleJson optional

Open baseplate-admin opened this issue 2 years ago • 2 comments

Closes #181

baseplate-admin avatar Jan 24 '23 15:01 baseplate-admin

Hi, Thanks for your response. I am a bit busy now. Will swing back to this PR soon.

I think we can take it a step further and just remove simplejson entirely now. I say this because it seems we only used simplejson to support python 2.7/3.3, as per their docs:

I also think stdlib's json does make more sense to support.

Before we apply merge the change, though, could we add a test case or two to advanced_filters/tests/test_q_serializer.py which ensure serialising and unserialising date and datetime values work?

Sure gimme some time

baseplate-admin avatar May 16 '23 03:05 baseplate-admin