modin icon indicating copy to clipboard operation
modin copied to clipboard

FEAT-#4605: Implementation of Small Query Compiler to support small and empty DataFrames

Open billiam-wang opened this issue 3 years ago • 5 comments

What do these changes do?

  • [ ] commit message follows format outlined here
  • [x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • [x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • [x] signed commit with git commit -s
  • [x] Resolves #4605
  • [x] tests added and passing
  • [x] module layout described at docs/development/architecture.rst is up-to-date

billiam-wang avatar Oct 10 '22 17:10 billiam-wang

This pull request introduces 9 alerts when merging fe123de71f23dfe852bbfa6bb74ae154f3c53f94 into f492ba9888fc05ff7c224db8a22faac8c0106a4b - view on LGTM.com

new alerts:

  • 7 for First parameter of a method is not named 'self'
  • 1 for Unused import
  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Oct 31 '22 09:10 lgtm-com[bot]

This pull request introduces 7 alerts when merging e0f36929ab8b4a6b5e7755714eaa72c61d891cf6 into 6f0ff798a23126a951b509ad3fea07e3d8c6b3db - view on LGTM.com

new alerts:

  • 7 for First parameter of a method is not named 'self'

lgtm-com[bot] avatar Oct 31 '22 17:10 lgtm-com[bot]

This pull request introduces 6 alerts when merging a3bac2c06ba1e6ce1d467f0281daf7ac870ada17 into 6f0ff798a23126a951b509ad3fea07e3d8c6b3db - view on LGTM.com

new alerts:

  • 6 for First parameter of a method is not named 'self'

lgtm-com[bot] avatar Oct 31 '22 18:10 lgtm-com[bot]

Do these changes need to be reflected in docs?

Garra1980 avatar Nov 01 '22 15:11 Garra1980

@billiam-wang, do you have a plan to continue this?

YarShev avatar Dec 05 '23 11:12 YarShev