modin icon indicating copy to clipboard operation
modin copied to clipboard

Published 20 hours ago • verified publisher icon modin-project

REFACTOR: delete `build-docker.py` as it's unused currently

Open anmyachev opened this issue 3 years ago • 5 comments

We also have no plans to use this file in the future.

anmyachev avatar Sep 15 '22 14:09 anmyachev

@anmyachev Action fail of PR delete build-docker.py , i don't know why not approve PR of os.popen(cmd) without deleting it ? i think should be approve about change code without delete file

gellanyhassan0 avatar Sep 15 '22 16:09 gellanyhassan0

@gellanyhassan0 your commit message - "Delete build-docker.py", but right version is "REFACTOR-#4980: delete build-docker.py". You can reopen last PR and I will fix the issue directly push in your branch if you not against that.

anmyachev avatar Sep 15 '22 16:09 anmyachev

@anmyachev Action fail of PR delete build-docker.py , i don't know why not approve PR of os.popen(cmd) without deleting it ?

Because this file is no longer used and we do not plan to use it in the future.

anmyachev avatar Sep 15 '22 16:09 anmyachev

@anmyachev do we need any of the scripts in ci/teamcity? I don't even think we use jenkins anymore?

pyrito avatar Sep 16 '22 19:09 pyrito

@anmyachev do we need any of the scripts in ci/teamcity? I don't even think we use jenkins anymore?

Remove jenkins folder here: https://github.com/modin-project/modin/pull/5002

anmyachev avatar Sep 19 '22 19:09 anmyachev