modin icon indicating copy to clipboard operation
modin copied to clipboard

REFACTOR: Refactor `full_axis` argument

Open RehanSD opened this issue 2 years ago • 1 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API? full_axis at the virtual partition level is used as a flag to tell the partition whether to block partition after or to materialize the result as a single partition - we should probably change it from full_axis to a more descriptive name that better reflects its usage.

RehanSD avatar Aug 02 '22 19:08 RehanSD

I think we can also stop making it a property of the axis object, and instead control the full_axis behavior with arguments to apply. apply seems to be the only thing that uses the full_axis argument.

edit: Or perhaps even better, always make apply return a single partition, and split the result with another method.

mvashishtha avatar Aug 02 '22 19:08 mvashishtha