modin icon indicating copy to clipboard operation
modin copied to clipboard

Published 20 hours ago • verified publisher icon modin-project

Rewrite Pandas version mismatch UserWarning

Open RehanSD opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API? I'd like to reformat the pandas version mismatch warning. I think it can be kind of confusing, since it seems to indicate Modin's version as the pandas version that is supported. E.g.:

UserWarning: The pandas version installed 1.4.3 does not match the supported pandas version in Modin 1.4.2. This may cause undesired side effects!

This seems to imply that Modin is currently version 1.4.2

RehanSD avatar Aug 02 '22 17:08 RehanSD

Maybe adding braces and some rephrasing would work?

UserWarning: The pandas version installed (1.4.3) does not match the pandas version Modin supports (1.4.2). This may cause undesired side effects!

vnlitvinov avatar Aug 02 '22 17:08 vnlitvinov

UserWarning: The pandas version installed (1.4.3) does not match the pandas version Modin supports (1.4.2). This may cause undesired side effects!

This LGTM.

mvashishtha avatar Aug 02 '22 17:08 mvashishtha

This seems like something that would be "low effort, high impact", so we should just get it merged ASAP.

pyrito avatar Aug 31 '22 21:08 pyrito