modin icon indicating copy to clipboard operation
modin copied to clipboard

Fix Modin conformance to data interchange API spec

Open vnlitvinov opened this issue 2 years ago • 1 comments

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): any
  • Modin version (modin.__version__): cfafbb254c221dd4f739a9cf5af17c9e8cdf13c3
  • Python version: any
  • Code we can use to reproduce:

Describe the problem

Since https://github.com/data-apis/dataframe-api/pull/74 and https://github.com/data-apis/dataframe-api/pull/69 were merged, the interchange spec has changed a little bit. We need to align our implementation with it.

Source code / logs

Note on testing: some bits in https://github.com/data-apis/dataframe-interchange-tests could be looked into.

vnlitvinov avatar Aug 01 '22 19:08 vnlitvinov

Note on testing: some bits in https://github.com/data-apis/dataframe-interchange-tests could be looked into.

FYI updates to the test suite are in https://github.com/data-apis/dataframe-interchange-tests/pull/11. Ignoring the roundtrip tests (as obviously everything's out of sync now), everything from #4763 looks good (save known issues).

pytest --disable-warnings tests/ -k "modin and not from_dataframe"

honno avatar Aug 08 '22 15:08 honno