STY: rename view/mask to take_2d and take_2d_labels_or_positional

[jbrockmendel]

• [x] commit message follows format outlined here
• [x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
• [x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
• [x] signed commit with git commit -s
• [x] Resolves #4729
• [ ] tests added and passing
• [x] module layout described at docs/development/architecture.rst is up-to-date
• [ ] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

[codecov[bot]]

Codecov Report

Merging #4739 (b79b8c4) into master (8f3f389) will increase coverage by 4.80%. The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master    #4739      +/-   ##
==========================================
+ Coverage   85.38%   90.18%   +4.80%     
==========================================
  Files         265      266       +1     
  Lines       19635    19918     +283     
==========================================
+ Hits        16765    17964    +1199     
+ Misses       2870     1954     -916     

Impacted Files	Coverage Δ
...me/pandas/interchange/dataframe_protocol/column.py	93.33% <ø> (ø)
...pandas/interchange/dataframe_protocol/dataframe.py	96.72% <ø> (ø)
...native/interchange/dataframe_protocol/dataframe.py	95.65% <ø> (ø)
modin/core/dataframe/pandas/dataframe/dataframe.py	94.76% <75.00%> (ø)
modin/core/dataframe/base/dataframe/dataframe.py	100.00% <100.00%> (ø)
modin/core/io/text/text_file_dispatcher.py	97.42% <100.00%> (ø)
modin/core/storage_formats/base/query_compiler.py	99.22% <100.00%> (ø)
...odin/core/storage_formats/pandas/query_compiler.py	96.59% <100.00%> (+0.56%)	:arrow_up:
...entations/omnisci_on_native/dataframe/dataframe.py	91.81% <100.00%> (ø)
...tal/core/storage_formats/omnisci/query_compiler.py	94.49% <100.00%> (ø)
... and 47 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[RehanSD]

PR looks good to me, but this does change our algebra (mask is considered an algebra operator). Should we just reframe and say that take is the algebra operator @devin-petersohn? Take makes less sense as an algebra name to me since I think mask has intuition behind it, but take does make sense in this case since Modin frames are immutable, and it parallels pandas.

[mvashishtha]

@RehanSD

since I think mask has intuition behind it

In my view, "mask" does evoke "boolean masking", which is similar to what these functions do, but on the other hand these functions are very different from pandas mask, so I prefer the names here.

this does change our algebra

I think it's fine for academic terms for operators to be different from the names in implementation :)

[RehanSD]

@RehanSD

since I think mask has intuition behind it

In my view, "mask" does evoke "boolean masking", which is similar to what these functions do, but on the other hand these functions are very different from pandas mask, so I prefer the names here.

this does change our algebra

I think it's fine for academic terms for operators to be different from the names in implementation :)

Hmm that makes sense to me! I'll go ahead and put an approval on it!

[jbrockmendel]

just rebased. based on today's call i think everyone is on board?

[mvashishtha]

based on today's call i think everyone is on board?

Yep.

@modin-project/modin-omnisci we need omnisci approval.