modin icon indicating copy to clipboard operation
modin copied to clipboard

FIX-#3180: Stop defaulting to pandas for paths relative to home.

Open mvashishtha opened this issue 3 years ago • 2 comments

Signed-off-by: mvashishtha [email protected]

What do these changes do?

FIX-#3180: Stop defaulting to pandas for paths relative to home.

  • [x] commit message follows format outlined here
  • [x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • [x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • [x] signed commit with git commit -s
  • [x] Resolves #3180
  • [x] tests added and passing
  • [x] module layout described at docs/development/architecture.rst is up-to-date
  • [x] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

mvashishtha avatar Jul 27 '22 07:07 mvashishtha

Codecov Report

Merging #4724 (e1692c1) into master (38450e1) will decrease coverage by 4.89%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #4724      +/-   ##
==========================================
- Coverage   85.21%   80.32%   -4.90%     
==========================================
  Files         259      260       +1     
  Lines       19217    19498     +281     
==========================================
- Hits        16376    15662     -714     
- Misses       2841     3836     +995     
Impacted Files Coverage Δ
modin/core/io/file_dispatcher.py 57.44% <50.00%> (-37.24%) :arrow_down:
modin/experimental/sklearn/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
modin/experimental/xgboost/test/test_dmatrix.py 0.00% <0.00%> (-100.00%) :arrow_down:
modin/experimental/xgboost/test/test_xgboost.py 0.00% <0.00%> (-100.00%) :arrow_down:
modin/experimental/core/execution/ray/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
...n/experimental/sklearn/model_selection/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
...mental/sklearn/model_selection/train_test_split.py 0.00% <0.00%> (-100.00%) :arrow_down:
...tal/core/execution/ray/implementations/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
...ecution/ray/implementations/pandas_on_ray/io/io.py 0.00% <0.00%> (-100.00%) :arrow_down:
...tion/ray/implementations/pandas_on_ray/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
... and 69 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jul 27 '22 07:07 codecov[bot]

@mvashishtha you have some CI failures and a merge conflict, please fix

vnlitvinov avatar Jul 29 '22 10:07 vnlitvinov

Fixed in https://github.com/modin-project/modin/pull/6448.

anmyachev avatar Aug 08 '23 21:08 anmyachev