modin icon indicating copy to clipboard operation
modin copied to clipboard

FIX-#4680: fix `read_csv` that started defaulting to pandas again in case of reading from a buffer and when a buffer has a non-zero starting position

Open anmyachev opened this issue 2 years ago • 2 comments

Signed-off-by: Myachev [email protected]

What do these changes do?

  • [x] commit message follows format outlined here
  • [x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • [x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • [x] signed commit with git commit -s
  • [x] Resolves #4680
  • [x] tests added and passing
  • [x] module layout described at docs/development/architecture.rst is up-to-date
  • [x] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

anmyachev avatar Jul 18 '22 13:07 anmyachev

Codecov Report

Merging #4681 (17c4aa1) into master (cfafbb2) will increase coverage by 4.48%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4681      +/-   ##
==========================================
+ Coverage   85.26%   89.74%   +4.48%     
==========================================
  Files         259      260       +1     
  Lines       19215    19498     +283     
==========================================
+ Hits        16383    17499    +1116     
+ Misses       2832     1999     -833     
Impacted Files Coverage Δ
modin/core/io/text/text_file_dispatcher.py 97.42% <100.00%> (ø)
modin/logging/config.py 94.59% <0.00%> (-1.30%) :arrow_down:
modin/experimental/batch/test/test_pipeline.py 94.56% <0.00%> (ø)
modin/pandas/series.py 94.33% <0.00%> (+0.24%) :arrow_up:
modin/pandas/series_utils.py 99.43% <0.00%> (+0.56%) :arrow_up:
modin/core/io/text/excel_dispatcher.py 94.01% <0.00%> (+0.85%) :arrow_up:
...ns/pandas_on_ray/partitioning/partition_manager.py 82.19% <0.00%> (+1.36%) :arrow_up:
...tations/pandas_on_python/partitioning/partition.py 93.75% <0.00%> (+2.08%) :arrow_up:
modin/config/envvars.py 88.78% <0.00%> (+3.41%) :arrow_up:
...dataframe/pandas/partitioning/partition_manager.py 90.15% <0.00%> (+3.69%) :arrow_up:
... and 31 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jul 18 '22 13:07 codecov[bot]

@vnlitvinov could you review that?

anmyachev avatar Jul 27 '22 22:07 anmyachev