modin icon indicating copy to clipboard operation
modin copied to clipboard

FEAT-#4574: Warn users when pre-initialized Ray cluster is not using all available memory

Open RehanSD opened this issue 2 years ago • 3 comments

Signed-off-by: Rehan Durrani [email protected]

What do these changes do?

  • [x] commit message follows format outlined here
  • [x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • [x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • [x] signed commit with git commit -s
  • [ ] Resolves #4574 ?
  • [ ] tests added and passing
  • [ ] module layout described at docs/development/architecture.rst is up-to-date
  • [ ] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

RehanSD avatar Jun 14 '22 18:06 RehanSD

Codecov Report

Merging #4575 (d98fed0) into master (4ec7f63) will increase coverage by 3.18%. The diff coverage is n/a.

:exclamation: Current head d98fed0 differs from pull request most recent head 3286ccc. Consider uploading reports for the commit 3286ccc to get more accurate results

@@            Coverage Diff             @@
##           master    #4575      +/-   ##
==========================================
+ Coverage   86.22%   89.40%   +3.18%     
==========================================
  Files         228      229       +1     
  Lines       18451    18727     +276     
==========================================
+ Hits        15909    16743     +834     
+ Misses       2542     1984     -558     
Impacted Files Coverage Δ
modin/core/execution/ray/common/utils.py 96.87% <ø> (ø)
modin/experimental/batch/test/test_pipeline.py 100.00% <0.00%> (ø)
modin/pandas/base.py 94.81% <0.00%> (+0.08%) :arrow_up:
modin/core/storage_formats/pandas/parsers.py 90.22% <0.00%> (+1.26%) :arrow_up:
...mentations/pandas_on_ray/partitioning/partition.py 93.57% <0.00%> (+1.83%) :arrow_up:
...tations/pandas_on_python/partitioning/partition.py 93.75% <0.00%> (+2.08%) :arrow_up:
...entations/pandas_on_dask/partitioning/partition.py 91.46% <0.00%> (+2.43%) :arrow_up:
modin/pandas/__init__.py 69.69% <0.00%> (+3.03%) :arrow_up:
...dataframe/pandas/partitioning/partition_manager.py 90.00% <0.00%> (+3.44%) :arrow_up:
modin/config/envvars.py 86.63% <0.00%> (+3.46%) :arrow_up:
... and 15 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jun 14 '22 19:06 codecov[bot]

@RehanSD what's the status of this PR?

vnlitvinov avatar Sep 09 '22 15:09 vnlitvinov

@vnlitvinov it's ready for review!

RehanSD avatar Sep 11 '22 11:09 RehanSD