modin icon indicating copy to clipboard operation
modin copied to clipboard

Move OmniSci engine usage from experimental feature to main ones

Open YarShev opened this issue 3 years ago • 10 comments

We should move OmniSci engine usage from experimental feature to main ones.

YarShev avatar Nov 02 '21 12:11 YarShev

what does it mean - move usage from experimental to main?

Garra1980 avatar Nov 02 '21 12:11 Garra1980

Move content related to OmniSci engine from modin/experimental/core to modin/core and avoid setting MODIN_EXPERIMENTAL=1.

YarShev avatar Nov 02 '21 12:11 YarShev

@aregm was against this iirc. Probably smth has been changed

Garra1980 avatar Nov 02 '21 14:11 Garra1980

I am okay with moving it out of experimental. It is a bit more mature now.

devin-petersohn avatar Nov 16 '21 15:11 devin-petersohn

Yes, let's try to put it in 0.13.

YarShev avatar Nov 16 '21 18:11 YarShev

Added to 0.13.0 release

devin-petersohn avatar Nov 29 '21 18:11 devin-petersohn

Let's use this task as epic and track here all efforts of moving Omnisci engine to experimental - main idea is to make all Modin tests work when Omnisci engine is enabled, i.e. either work on native Omnisci or default to pandas

Garra1980 avatar Dec 01 '21 14:12 Garra1980

This is an epic issue. List of individual issues is below:

  • [x] #3788
  • [x] #3800
  • [x] #3802
  • [x] #3810
  • [x] #3812
  • [ ] #3813
  • [x] #3814
  • [x] #3815
  • [ ] #3822
  • [x] #3823
  • [x] #3824
  • [x] #3825
  • [x] #3834
  • [x] #3836
  • [x] #3837
  • [x] #3838
  • [x] #3839
  • [x] #3840
  • [x] #3841
  • [x] #3842
  • [x] #3906
  • [x] #3913
  • [x] #3916
  • [x] #3917
  • [x] #3924
  • [x] #3925
  • [x] #3928
  • [x] #3931
  • [x] #3932
  • [x] #3933
  • [x] #3940
  • [x] #3941
  • [x] #3942
  • [x] #3951
  • [x] #3952
  • [x] #3969
  • [x] #3970
  • [x] #3983
  • [x] #3984
  • [x] #4008
  • [x] #4016
  • [x] #4022
  • [x] #4023
  • [x] #4038
  • [x] #4039
  • [x] #4040
  • [x] #4042
  • [x] #4066
  • [x] #4067
  • [x] #4068
  • [x] #4069
  • [x] #4086
  • [x] #4090
  • [x] #4091
  • [x] #4099
  • [x] #4100
  • [x] #4101
  • [ ] #4102
  • [x] #4103
  • [x] #4104
  • [x] #4107
  • [x] #4121

Rubtsowa avatar Dec 08 '21 16:12 Rubtsowa

@Garra1980 almost all issues in the tracker have been fixed. It might be worth updating the tracker and considering moving it from experimental in the nearest release.

anmyachev avatar Oct 26 '23 23:10 anmyachev

Thanks a lot for checking all subsidiary issues! I support the idea to give this issue a go - let's plan to move it forward for the upcoming releases

Garra1980 avatar Oct 27 '23 16:10 Garra1980

https://github.com/modin-project/modin/issues/7234

anmyachev avatar May 05 '24 16:05 anmyachev