flopy icon indicating copy to clipboard operation
flopy copied to clipboard

feat: Added simple function to mfdis.py

Open camille12225 opened this issue 1 year ago • 4 comments

New function returns 3 lists of integers for

  1. Stress periods in the model
  2. Timesteps in each stress period
  3. Length of each timestep

camille12225 avatar Jan 12 '24 00:01 camille12225

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 73.0%. Comparing base (96ede0d) to head (3c60197). Report is 77 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2056     +/-   ##
=========================================
- Coverage     73.0%   73.0%   -0.1%     
=========================================
  Files          259     259             
  Lines        59298   57932   -1366     
=========================================
- Hits         43305   42294   -1011     
+ Misses       15993   15638    -355     
Files Coverage Δ
flopy/modflow/mfdis.py 89.1% <9.0%> (-2.8%) :arrow_down:

... and 72 files with indirect coverage changes

codecov[bot] avatar Jan 12 '24 14:01 codecov[bot]

You will need to relint with black (see failed test). Also to maintain code coverage you need to add a small test of your function that confirms that you get expected results for a known case.

jdhughes-usgs avatar Jan 12 '24 14:01 jdhughes-usgs

Sure, I reformatted with black. I will push again when I add the CI test.

camille12225 avatar Jan 12 '24 17:01 camille12225

@camille12225 develop has moved a lot and linting has switched to ruff since this was opened, in case you need to again it can be done with ruff check . and ruff format . from the project root. It looks like this PR doesn't need a rebase before merging though.

wpbonelli avatar May 04 '24 00:05 wpbonelli