flopy icon indicating copy to clipboard operation
flopy copied to clipboard

feat get budget by second package name `paknam2`

Open ougx opened this issue 2 years ago • 2 comments

feat get budget by second package name paknam2

ougx avatar Dec 21 '23 23:12 ougx

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 73.1%. Comparing base (1fe5157) to head (61a63e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2050   +/-   ##
=======================================
  Coverage     73.1%   73.1%           
=======================================
  Files          259     259           
  Lines        59511   59513    +2     
=======================================
+ Hits         43510   43516    +6     
+ Misses       16001   15997    -4     
Files Coverage Δ
flopy/utils/binaryfile.py 83.4% <93.0%> (+0.4%) :arrow_up:

codecov[bot] avatar Dec 21 '23 23:12 codecov[bot]

Hey @ougx, thanks for taking a shot at this! I suspect it is going to take a little more work to get this right and working for all MODFLOW versions. As you probably know, there is not an easy way to get package flows out of the budget file when there are multiple packages of the same type. Do we leave everything the same but support a budobj.get_data(pname="CHD-1") option?

christianlangevin avatar Dec 22 '23 12:12 christianlangevin

@langevin-usgs : there is not an easy way to get package flows out of the budget file when there are multiple packages of the same type. The purpose of this PR is exactly resolve this issue. With the current version, there is no way to extract flux from MVR budget file. Please let me know if you have other suggestions. Thanks!

ougx avatar Mar 07 '24 14:03 ougx

@ougx, thanks for this. I added a test and made a small change to the paknam2 docstring. I'll merge when the tests pass.

christianlangevin avatar Mar 13 '24 21:03 christianlangevin