Zenject icon indicating copy to clipboard operation
Zenject copied to clipboard

Add missing meta file in Zenject package

Open MrCheez opened this issue 3 years ago • 2 comments

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [x] ~~Tests for the changes have been added (for bug fixes / features)~~
  • [x] ~~Docs have been reviewed and added / updated if needed (for bug fixes / features)~~
  • [x] No compiler errors or warnings

Pull request type

Please check the type of change your PR introduces:

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

Issue Number

Issue Number: #221

What is the current behavior?

  • The Unity package version is missing a .meta file for the OptionalExtras/Async folder
  • Adding Zenject via UPM results in a UPM exception: image

What is the new behavior?

  • The .meta file of the UnityProject/Assets/Plugins/Zenject/OptionalExtras/Async folder has been added to the repository
  • Cloning the Zenject package via UPM no longer results in a missing meta file for immutable files exception

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

On which Unity version has this been tested?

  • [ ] 2020.4 LTS
  • [ ] 2020.3
  • [x] 2020.2
  • [ ] 2020.1
  • [ ] 2019.4 LTS
  • [ ] 2019.3
  • [ ] 2019.2
  • [ ] 2019.1
  • [ ] 2018.4 LTS

Scripting backend:

  • [ ] Mono
  • [ ] IL2CPP

Note: Every pull request is tested on the Continuous Integration (CI) system to confirm that it works in Unity.

Ideally, the pull request will pass ("be green"). This means that all tests pass and there are no errors. However, it is not uncommon for the CI infrastructure itself to fail on specific platforms or for so-called "flaky" tests to fail ("be red"). Each CI failure must be manually inspected to determine the cause.

CI starts automatically when you open a pull request, but only Releasers/Collaborators can restart a CI run. If you believe CI is giving a false negative, ask a Releaser to restart the tests.

MrCheez avatar Jul 05 '21 13:07 MrCheez

Is there anything I can do to speed up the merge/review process @Mathijs-Bakker @nonumpa?

MrCheez avatar Aug 10 '21 12:08 MrCheez

I have no idea. I approved just because I also need this fix.

nonumpa avatar Aug 25 '21 13:08 nonumpa