web icon indicating copy to clipboard operation
web copied to clipboard

feat(test-runner-browserstack): Make the local proxy configurable

Open fbuecklers opened this issue 1 year ago • 3 comments

What I did

  1. I introduced a top level local options, which allow you to disable the local proxy setup. This is specially useful when you just want to test public reachable domains
  2. I have made the internal IP lookup conditional based on the capability.local flag, to make sure that it will only be run in cases it is really needed. This is also useful in CI environments where the ip command may not be available. Even an import of the module has previously crashed such CI runs.

fbuecklers avatar Oct 16 '24 15:10 fbuecklers

🦋 Changeset detected

Latest commit: ec574b7f6c71560bfc9aa27a492ac32d601ef9f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/test-runner-browserstack Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 16 '24 15:10 changeset-bot[bot]

Hi @Westbrook Thanks for the quick review. I have hopefully addressed your points

fbuecklers avatar Nov 05 '24 17:11 fbuecklers

@Westbrook Does it look good for you now?

fbuecklers avatar Nov 08 '24 19:11 fbuecklers