web icon indicating copy to clipboard operation
web copied to clipboard

[rollup-plugin-import-meta-assets] Fix resolving and respect `external` rollup option

Open CGNonofr opened this issue 1 year ago • 6 comments

The plugin currently doesn't support:

  • custom resolvers (it just resolves the path with node path tool)
  • external configuration (everything is considered as internal and bundled)

That PR implements that

CGNonofr avatar Oct 07 '24 13:10 CGNonofr

⚠️ No Changeset found

Latest commit: f7843763bef3983c3f7644f366f639d330167958

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 07 '24 13:10 changeset-bot[bot]

can you please add unit tests?

bashmish avatar Oct 10 '24 10:10 bashmish

can you please add unit tests?

done! fixed the current test and added a new test

CGNonofr avatar Oct 10 '24 15:10 CGNonofr

Btw, I'm not sure about the "ignore if it's a directory" feature, I don't really see the point of it, and the user can now explicitely ignore it by setting it as external

CGNonofr avatar Oct 10 '24 15:10 CGNonofr

Just fixed the tests for windows

CGNonofr avatar Oct 10 '24 17:10 CGNonofr

up?

CGNonofr avatar Nov 08 '24 09:11 CGNonofr