web
web copied to clipboard
[rollup-plugin-import-meta-assets] Fix resolving and respect `external` rollup option
The plugin currently doesn't support:
- custom resolvers (it just resolves the path with node
pathtool) - external configuration (everything is considered as internal and bundled)
That PR implements that
⚠️ No Changeset found
Latest commit: f7843763bef3983c3f7644f366f639d330167958
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
can you please add unit tests?
can you please add unit tests?
done! fixed the current test and added a new test
Btw, I'm not sure about the "ignore if it's a directory" feature, I don't really see the point of it, and the user can now explicitely ignore it by setting it as external
Just fixed the tests for windows
up?