modernweb-dev
chore: upgrade esbuild to 0.20.x
This just bumps esbuild to 0.20.x
it'll help de-dupe a lot of my dependency tree since many of our other dependencies are using esbuild 0.20.x 👀
🦋 Changeset detected
Latest commit: dc2351761cd18731857eb902281fe72e3ce41811
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 3 packages
| Name | Type |
|---|---|
| rollup-plugin-workbox | Patch |
| @web/dev-server-esbuild | Patch |
| @web/storybook-builder | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
i think this is blocked until storybook also moves to esbuild 0.20.x
i have a PR here: storybookjs/storybook#26255
i think this is blocked until storybook also moves to esbuild 0.20.x
why do you think it's blocked? in theory the storybook-builder is decoupled from storybook not entirely, because the integration is done via a Connect middleware, but esbuild doesn't play a role there so I think we can accept that storybook-builder has a newer esbuild version than the storybook core
I figured there will be another issue: chialab esbuild plugins used in the storybook-builder are on esbuild 0.19.x (e.g. esbuild-plugin-commonjs), those need compatibility. Can you raise a PR in their repo?
ah you are right, it isn't storybook, it is the commonjs plugin
basically, our Plugin type we import from esbuild is different than the Plugin the commonjs plugin exports (esbuild-plugin-commonjs)
so we need to upgrade that repo upstream first
What about this one? Seems like https://github.com/chialab/rna/tree/main/packages/esbuild-plugin-commonjs was updated quite a while ago 🤔
I figured there will be another issue: chialab esbuild plugins used in the storybook-builder are on esbuild 0.19.x (e.g. esbuild-plugin-commonjs), those need compatibility. Can you raise a PR in their repo?
btw this is not an issue anymore, since we don't use chialab esbuild plugins anymore
@43081j can you please look into updating this PR? the conflicts need to be resolved and we might be able to jump right to [email protected]
updated to be 0.24.0, but it seems CI fails for unrelated reasons in one of the test runs
not too sure what's going on there 🤔 second pair of eyes would be good
Looks to be related to new node 23 released on Oct 16 https://nodejs.org/en/blog/release/v23.0.0
I tested current master with it locally, also breaks.
@43081j please rebase with latest master to get Node 22 testing back. There will still be failure on Node 23, but that's OK for now, I'll merge with it since it's really not related.
Also small remark: please update the PR title and the changeset to mention 0.24.x instead of 0.20.x
@43081j any update on this?
UPDATE: just thinking if I have access to the PR myself as a maintainer, will try to update
Sorry!
I lost track of this as I've been pretty busy travelling
I have it locally mid rebase but ran into a bunch of dependency problems. I can try again in the next day or two unless you beat me to it