web icon indicating copy to clipboard operation
web copied to clipboard

Update puppeteer to version 22.0.0

Open Sanderovich opened this issue 1 year ago • 5 comments

Updated Puppeteer to its latest major. See #2646 for more context

Sanderovich avatar Feb 21 '24 16:02 Sanderovich

🦋 Changeset detected

Latest commit: 4cc90648a78b36a5d1a72f1bf42508d019af7c71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@web/test-runner-puppeteer Minor
@web/test-runner-chrome Minor
@web/test-runner-junit-reporter Patch
@web/test-runner Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 21 '24 16:02 changeset-bot[bot]

I'd love to land this but we'd need to fix the npm registry bit.

koddsson avatar Feb 22 '24 09:02 koddsson

I think this will fix the flakyness with CI so it would be great to land this.

cc/ https://github.com/puppeteer/puppeteer/issues/11967

koddsson avatar Feb 22 '24 11:02 koddsson

@koddsson Thanks for the review! I resolved your comments

Sanderovich avatar Feb 22 '24 13:02 Sanderovich

@koddsson Thanks for the review! I resolved your comments

The package-lock.json was a bit messed up and I just pushed a commit that I think fixes it.

koddsson avatar Feb 22 '24 13:02 koddsson

Just realised that we might have a bunch of docs referencing the devices, and turned out to be true. Can you please check and update those? I think this means not just removing, but changing the documentation to use new recommended imports from puppeteer.

bashmish avatar Mar 04 '24 17:03 bashmish

@bashmish I updated the imports in the docs. Additionally, I see the playwright packages are also exporting a devices variable, but I kept those as is to keep the focus of the PR on updating Puppeteer.

Sanderovich avatar Mar 05 '24 14:03 Sanderovich

I think it's the very last comment about the versions you need to bump, then we can merge this I wasn't sure what packages would be impacted by the devices change, so needed to see your last changes brefore bringing this up

bashmish avatar Mar 05 '24 15:03 bashmish

@Sanderovich thanks a lot!

bashmish avatar Mar 06 '24 11:03 bashmish