web
web copied to clipboard
Update puppeteer to version 22.0.0
Updated Puppeteer to its latest major. See #2646 for more context
🦋 Changeset detected
Latest commit: 4cc90648a78b36a5d1a72f1bf42508d019af7c71
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
Name | Type |
---|---|
@web/test-runner-puppeteer | Minor |
@web/test-runner-chrome | Minor |
@web/test-runner-junit-reporter | Patch |
@web/test-runner | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
I'd love to land this but we'd need to fix the npm registry bit.
I think this will fix the flakyness with CI so it would be great to land this.
cc/ https://github.com/puppeteer/puppeteer/issues/11967
@koddsson Thanks for the review! I resolved your comments
@koddsson Thanks for the review! I resolved your comments
The package-lock.json
was a bit messed up and I just pushed a commit that I think fixes it.
Just realised that we might have a bunch of docs referencing the devices
, and turned out to be true. Can you please check and update those? I think this means not just removing, but changing the documentation to use new recommended imports from puppeteer.
@bashmish I updated the imports in the docs. Additionally, I see the playwright packages are also exporting a devices variable, but I kept those as is to keep the focus of the PR on updating Puppeteer.
I think it's the very last comment about the versions you need to bump, then we can merge this
I wasn't sure what packages would be impacted by the devices
change, so needed to see your last changes brefore bringing this up
@Sanderovich thanks a lot!