web
web copied to clipboard
Convert everything to ESM
I think we just need to pull the bandaid off and deal with issues that arise. Trying to do this piece meal feels impossible.
🦋 Changeset detected
Latest commit: d9868b8720cfdeb583470cdfcb095a786c5517a3
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 38 packages
Name | Type |
---|---|
@web/storybook-framework-web-components | Major |
@web/rollup-plugin-import-meta-assets | Major |
@web/rollup-plugin-polyfills-loader | Major |
@web/test-runner-visual-regression | Major |
@web/test-runner-junit-reporter | Major |
@web/test-runner-browserstack | Major |
@web/test-runner-coverage-v8 | Major |
@web/dev-server-import-maps | Major |
@web/test-runner-playwright | Major |
rollup-plugin-workbox | Major |
@web/test-runner-puppeteer | Major |
@web/test-runner-saucelabs | Major |
@web/test-runner-webdriver | Major |
@web/dev-server-storybook | Major |
@web/test-runner-commands | Major |
@web/test-runner-selenium | Major |
@web/dev-server-polyfill | Major |
@web/dev-server-esbuild | Major |
@web/rollup-plugin-copy | Major |
@web/rollup-plugin-html | Major |
@web/test-runner-chrome | Major |
@web/dev-server-legacy | Major |
@web/dev-server-rollup | Major |
@web/storybook-builder | Major |
@web/test-runner-mocha | Major |
@web/polyfills-loader | Major |
@web/test-runner-core | Major |
@web/dev-server-core | Major |
@web/storybook-utils | Major |
@web/test-runner-cli | Major |
@web/dev-server-hmr | Major |
@web/config-loader | Major |
@web/browser-logs | Major |
@web/parse5-utils | Major |
@web/test-runner | Major |
@web/dev-server | Major |
@web/mocks | Major |
@web/test-runner-module-mocking | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
This looks exciting! Need to dig deeper on the code but some questions:
Have you tested the prerelease distributions of these packages in an external project? next
always releases these.
Would we need to also pull the bandaid in the Open WC packages to satisfy a “full” release of these type of changes?
Have you tested the prerelease distributions of these packages in an external project?
next
always releases these.
I did run it on one project I got at work but maybe I could do more installs. I was hoping other people might also check it out in their projects and report back if there are any errors.
Whoops!
@bashmish; this is now conflicting. Can you resolve those?
@bashmish; this is now conflicting. Can you resolve those?
done
I had to remove the "retrocompatibility" for import { globals } from '@storybook/preview/globals';
as it seems more difficult to support in the ESM world and not really needed given people will easily upgrade to latest storybook packages to resolve it, and I think it's needed for ESM anyway.
@koddsson shouldn't we also update the demos?