web icon indicating copy to clipboard operation
web copied to clipboard

ChromeLauncherPage always sets viewport to 800 x 600 ignoring createPage config

Open jasonmobley opened this issue 2 years ago • 0 comments

There's code in test-runner-chrome package that always sets the viewport size to 800 x 600. I tried to use the createPage config to override the viewport size and found that it had no effect.

Is there a reason why it's hardcoded to these dimensions? Could we expose config properties to override those or only set the viewport size if it hasn't already been set somehow?

https://github.com/modernweb-dev/web/blob/7fac51e0c773aa8d7129edd8f4b31b9c4aca7d99/packages/test-runner-chrome/src/ChromeLauncherPage.ts#L88

jasonmobley avatar Sep 01 '23 16:09 jasonmobley