modernweb-dev
fix: Export types from config-loader
What I did
- Added an export for types for the config-loader package
I was about to start using this package but had my typescript setup not finding the type declarations for it.
Turns out you have to add reference to the types as well, if you're declaring e.g. the import and require exports.
Source: https://webpack.js.org/guides/package-exports/#conditions
Should fix the "could not find a declaration file for module types" errors for this package
Not sure if there's other packages in this repo that could use this touch up too
🦋 Changeset detected
Latest commit: 3419ca3ad2ee3bbb7c8949ebe58a5f603563f2db
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @web/config-loader | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think this should cause a patch level version bump to the package, I'll try n figure out how to set that up
I'm like 100% that the tests aren't failing due to this change :D Could this get a look/merge?
@Matsuuu can you bring this branch up to date with the latest changes on master? that should make CI pass
Welp. Time escaped me last week. Did it now, let's see if the CI runs nicely