modernweb-dev
feat(dev-server-esbuild): allow extended tsconfig
What I did
- Added a test case when referencing a
tsconfig.jsonin theesbuildPluginthat uses extends to extend from a basetsconfig.json - Added a possible implementation how it could work using
--showConfigwhen runningtsc. See https://www.typescriptlang.org/docs/handbook/compiler-options.html - Change the
targetof the fixture, since es2022 was reported as invalid bytsc
I'm not sure about the actual implementation, but it covers my test case, without breaking the other tests of dev-server-esbuild (at least on Mac) 🤷🏽
🦋 Changeset detected
Latest commit: 99ae9054ca8136464edb20173c69ccc37bdfeca9
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @web/dev-server-esbuild | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
changeset-bot message...
So if I understand this correctly, I can trigger an automatic release of the package, by applying a change set?
Apply the changeset to clarify that there are changes requiring a release.
Full the changeset with a lingual representation of the changes so that they are included in the CHANGELOG.md.
Apply the changeset to clarify that there are changes requiring a release.
Full the changeset with a lingual representation of the changes so that they are included in the CHANGELOG.md.
Let me know if the formatting of the changeset should be adjusted!
We've got #2180 queued up to merge to master soon. I want to make sure we land that first so that we don't delay that release any more. We'll merge this once that PR has landed.
No worries, I've come across another way to possibly solve it while going through the dependabot PR's at work. Would something like this be preferred over shelling out tsc? https://github.com/qmhc/vite-plugin-dts/pull/202
You are still using the typescript ecosystem, but have to do a bit more manual recursion in favour of not having to run a command.
EDIT: Also sorry for the re-review, I was worried you might not have seen this message, before potentially merging this PR.
No worries, I've come across another way to possibly solve it while going through the dependabot PR's at work. Would something like this be preferred over shelling out
tsc? qmhc/vite-plugin-dts#202
Oh, yeah! I would love to do this instead. Looks like we need to upgrade to TypeScript 5 first, which I think is also a positive, so I'd prefer that.
What do you think?
No worries, I've come across another way to possibly solve it while going through the dependabot PR's at work. Would something like this be preferred over shelling out
tsc? qmhc/vite-plugin-dts#202Oh, yeah! I would love to do this instead. Looks like we need to upgrade to TypeScript 5 first, which I think is also a positive, so I'd prefer that.
What do you think?
Yeah, I think it might be better, but it does indeed seem to require typescript 5. Would that then be considered a breaking change for dev-server-esbuild?
Would that then be considered a breaking change for dev-server-esbuild?
Probably! But that's no worries, we can just make a breaking change.
We should be on TypeScript 5 now if you pull master 👯
I'll modify my PR somewhere this weekend, I have busy schedule for this week unfortunately.
We should be on TypeScript 5 now if you pull master 👯
I'll modify my PR somewhere this weekend, I have busy schedule for this week unfortunately.
No worries! Let me know if we can help :)