web icon indicating copy to clipboard operation
web copied to clipboard

[test-runner-visual-regression] cannot distinguish between chromium browsers(getBaselineName, getDiffName, getFailedName)

Open sijakret opened this issue 2 years ago • 0 comments

Hey,

this context, passed down to the visual diff command (and eventually to the helpers that generate the screenshot file names only hands down session.browser.name. This seems to be "chromium" for all chromium-based browsers (like chrome, edge, etc..) so in a session where multiple of these are present the screenshot paths have collisions. Wouldn't it make sense to hand down more context here (like browser channel and browser version!?)

image

Best, Jan

sijakret avatar Jul 11 '22 12:07 sijakret