web
web copied to clipboard
Test runner logger and reporters modules
This PR introduces two dedicated modules for test runner logger and test runner reporters. As discussed here, providing a dedicated module for reporters utils (such as the progress bar) is helpful plugins author.
What I did
- Created new package for
test-runner-logger
- Moved logger sources into the new module
- Updated references in
test-runner
package - Created new package for
test-runner-reporters
- Moved reporters sources into the new module
- Updated references in
test-runner
package
Notes
- The
test-runner
package re-exports reporters for backward compatibility
⚠️ No Changeset found
Latest commit: 7eaf64c4c34de8af69a5d581a0e53844df50aa72
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Some questions for review: Should these be in
- separate packages (as per initial pr),
- a single
test-runner-helpers
package, or - a package export from
test-runner
? I'm thinking (3) is preferable, as it would be the smallest addition to the API surface that still fulfills the original requirement.
IMO, using the test-runner
package as dependency is not preferable because it downloads and loads a lot of stuff for cli and the whole runner usage. May I add option 4: move logger and reporters to test-runner-core
?
🤔 mmm yeah considering that, I change my preference to either core, like you suggested, or a new helpers package. Let's see what @LarsDenBakker and @web-padawan have to say about it