web icon indicating copy to clipboard operation
web copied to clipboard

fix: support rollup plugins in manager.js

Open castastrophe opened this issue 4 years ago • 2 comments

What I did

I noticed that running build-storybook was not reading in the rollup image plugin necessary for theme.js to load a brand image. No issues with this in the web-dev-server command for running the local preview. This adds processing for the rollup plugins for the manager assets as well.

castastrophe avatar Dec 17 '21 18:12 castastrophe

🦋 Changeset detected

Latest commit: e186df0a7b034532b1d14a4021b15bba02148db0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/dev-server-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Dec 17 '21 18:12 changeset-bot[bot]

I think it's better to introduce a new option for this, as most plugins should be used for the preview (that's where the user's own code is). Plugins for the preview might conflict with the manager code, or at the least make it slower.

LarsDenBakker avatar Dec 18 '21 16:12 LarsDenBakker