web
web copied to clipboard
[test-runner-visual-regression] Feature Request. extend VisualDiffCommandContext to include launch options
Hi,
when running chrome using the msedge channel like this
playwrightLauncher({ product: 'chromium', launchOptions: { channel: 'msedge' } })
as far as i can see it is currently not possible to access the, for instance, the launch options to generate a different paths for edge and chromium: https://github.com/modernweb-dev/web/blob/e5f1935973c078354c82b9882fdbb54364751574/packages/test-runner-visual-regression/src/visualDiffCommand.ts#L32
So if they are running in parallel in one session it is not possible to distinguish them in getBaselineName
.
Should we maybe add the launch options to the context available to that method?
https://github.com/modernweb-dev/web/blob/e5f1935973c078354c82b9882fdbb54364751574/packages/test-runner-visual-regression/src/visualDiffCommand.ts#L20
what are your thoughts?
Thanks for the issue. I think we can consider this an enhancement. Feel free to submit a PR to address this.