web icon indicating copy to clipboard operation
web copied to clipboard

feat!: update dependency @rollup/plugin-commonjs to v21

Open renovate[bot] opened this issue 4 years ago • 5 comments

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@rollup/plugin-commonjs (source) ^18.0.0 -> ^21.1.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] avatar Oct 01 '21 17:10 renovate[bot]

🦋 Changeset detected

Latest commit: a7f47727fe4b8824f119fd4d99682727d2c4dd76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@web/dev-server-rollup Minor
@web/dev-server Minor
@web/test-runner Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 01 '21 17:10 changeset-bot[bot]

One test fails on Windows and I'm not sure what's the reason 🤔

  1) @rollup/plugin-commonjs
       can transform an es module compiled to commonjs module with a default exports:
     Error: Expected "import { __exports as foo } from "/__web-dev-server__/rollup/foo.js?web-dev-server-rollup-null-byte=%00" in string: 

import * as commonjsHelpers from "/__web-dev-server__/rollup/commonjsHelpers.js?web-dev-server-rollup-null-byte=%00commonjsHelpers.js";
import { __exports as foo } from "D:\a\web\web\packages\dev-server-rollup\test\node\fixtures\basic\foo.js?commonjs-exports"

web-padawan avatar Oct 07 '21 10:10 web-padawan

A minor version bump is for breaking changes since we are still on v0. Its a dev dependency so no need to really do a version bump

LarsDenBakker avatar Oct 07 '21 11:10 LarsDenBakker

We also need to double check if https://github.com/modernweb-dev/web/issues/1700 is still an issue with @rollup/plugin-commonjs v21.

web-padawan avatar Oct 07 '21 14:10 web-padawan

Autoclosing Skipped

This PR has been flagged for autoclosing, however it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

renovate[bot] avatar Oct 07 '21 17:10 renovate[bot]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

renovate[bot] avatar Nov 28 '22 13:11 renovate[bot]

Closing as out of date.

Westbrook avatar Mar 11 '23 21:03 Westbrook