web
web copied to clipboard
modernweb-dev
Make snapshot directory configurable
We currently store snapshots next to the test file itself. This doesn't work out when you are using a compiler and output to a separate directory. We should make the snapshot directory configurable.
This would be very helpful, currently I have to set up exceptions in .gitignore to check only the snapshots folder, which is a bit cumbersome.
Are there any updates on this issue? We are moving from karma to web-test-runner and this is the still an inconvenience.
I opened a PR about this about a week ago: https://github.com/modernweb-dev/web/pull/1866
I'm not sure if there's some protocol I need to follow in order to get someone to give it a look-see, or if everyone's just busy with other things for now.
@LarsDenBakker any thoughts on the PR? The dom snapshots currently feel a bit awkward on Typescript due to this. I was not entirely sure if the way I implemented it in the PR was an optimal way, but I can also work more on this if there are some better ideas.