web
web copied to clipboard
modernweb-dev
feat(rollup-plugin-html): include video and source assets
🦋 Changeset detected
Latest commit: c845409e5efeed79c283786d602e20670de94b84
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @web/rollup-plugin-html | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think I need some help with this PR, I cannot figure out why the tests are failing.
As soon as I add image-d (poster attr for video), suddenly it cannot find the image-c asset, and I can't figure out why it behaves that way :\
I kinda need this PR for my site which uses <video> & <source> elements
@jorenbroekema maybe this PR https://github.com/modernweb-dev/web/pull/1541 meets your needs for video and source tags?
@gdbaldw yep, very nice. I still think this PR should be done at some point to make those tags work by default without needing to specify them manually, since they are native html tags that contain a reference to an asset, but I've given up making the flaky test work :P so your PR will at least enable me to extract those video assets