rocket icon indicating copy to clipboard operation
rocket copied to clipboard

Improve formatting the title of the search results

Open blackgwe opened this issue 4 years ago • 5 comments

The categories of the search results could be improved, e.g. using breadcrumb delimiters like "»".

Currently the following search terms are not rendered prettily:

search for "small"

t > Why Rocket?
<strong>Small</strong>

search for "frontend"

Rocket &gt; Why Rocket?Small
Bildschirmfoto 2021-01-22 um 07 30 25

blackgwe avatar Jan 22 '21 06:01 blackgwe

good catch - we planned to work on search improvements in a 2-3 weeks...

if this is something of a priority for you then we can prioritise it for earlier - let us know 🤗

daKmoR avatar Jan 24 '21 13:01 daKmoR

Some improvements I would recommend, and could help implement

  • Make the results change cursor to pointer . (Twitter and Github do this)
  • If the text content is cut off from the start, add a ... before it.
  • As @blackgwe suggested, use some kind of breadcrumb delimiter for all parts. One would be needed also between (in example image) the "Why Rocket?" and "Small" in my opinion.

Matsuuu avatar Feb 22 '21 19:02 Matsuuu

indeed there are also a few other improvements we should make

https://github.com/daKmoR/rocket/issues/119

daKmoR avatar Feb 22 '21 19:02 daKmoR

I could maybe take a shot at applying these improvements :)

Matsuuu avatar Feb 22 '21 19:02 Matsuuu

I've added quite some of these fixes in a PR here .

We might have to think about how to get the sub-titles formatted more nicely. A quick look at the code seemed to couple the "Why Rocket?" and "Small" onto the same object.

Could we somehow split the subtitles into their own object?

Matsuuu avatar Feb 23 '21 07:02 Matsuuu