BloodOath timing is inaccurate

[kamronbatman]

Since BloodOauth uses a 1s interval, it is sometimes late. We should use OnDeath and OnDelete to look up the Caster (or the target), and call RemoveCurse appropriately instead. This way the ExpireTimer can just cleanly call RemoveCurse too instead of being an interval.

[Bohicatv]

line 70; _oathTable[Caster] = Caster;

I believe the table value should be updated for m not Caster

[kamronbatman]

@mark1145 can you take a look too?

[Bohicatv]

For example, (if I'm reading this right) m is technically not being calculated correctly on the oath table, because Caster is getting both the key and the value as Caster.

_oathTable[Caster] = Caster; _oathTable[m] = Caster;

to (stores value to m)

_oathTable[Caster] = m; _oathTable[m] = Caster;

Also, line 83; should not be fixed point; var duration = TimeSpan.FromSeconds((GetDamageSkill(Caster) - GetResistSkill(m)) / 8 + 8); if we are going for era behavior accuracy.