ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard
verified publisher icon modelica

Missing 'each' in Modelica.Electrical.QuasiStatic.Polyphase.Blocks.FromSymmetricalComponents

Open casella opened this issue 4 months ago • 4 comments

The Modelica.Electrical.QuasiStatic.Polyphase.Blocks.FromSymmetricalComponents contains two illegal displayUnit modifiers, missing the each prefix: https://github.com/modelica/ModelicaStandardLibrary/blob/3f72865f0764cad0f2fb2d47d1e3fc0bf96ec4e6/Modelica/Electrical/QuasiStatic/Polyphase/Blocks/FromSymmetricalComponents.mo#L9-L13

This somehow escaped our testing, probably because the model was never used in an actual test model, otherwise OpenModelica would have caught it.

We should fix this on master and on 4.1.1.

casella avatar Jul 28 '25 18:07 casella

See OpenModelica/OpenModelica#14151

casella avatar Jul 28 '25 18:07 casella

the model was never used in an actual test model

In general, I would consider this a problem in itself. Ideally all classes should be used in at least one example or test model.

maltelenz avatar Jul 29 '25 06:07 maltelenz

the model was never used in an actual test model

In general, I would consider this a problem in itself. Ideally all classes should be used in at least one example or test model.

There already is an open issue: #1539

Especially, see https://github.com/modelica/ModelicaStandardLibrary/issues/1539#issuecomment-3133670889

Image

beutlich avatar Jul 29 '25 19:07 beutlich

@casella Sorry I'm going to have a surgery on Friday, and I'll be not available in August. I'll take care after the conference in September.

AHaumer avatar Jul 30 '25 10:07 AHaumer