ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard

Add starting point for figures in Mechanics.Rotational.

Open maltelenz opened this issue 6 months ago • 3 comments

These originate from figures created for Wolfram System Modeler, and are likely to need cleanup and improvement.

Our one existing figure in MSL is probably a good style to follow:

https://github.com/modelica/ModelicaStandardLibrary/blob/3f72865f0764cad0f2fb2d47d1e3fc0bf96ec4e6/Modelica/Blocks/package.mo#L159-L180

Creating as Draft to indicate that library officer(s) probably want/should improve them before merging.

maltelenz avatar Jul 16 '25 10:07 maltelenz

@maltelenz First of all, thanks for reaching out and opening this and related "mechanical" issues.

Generally, I would prefer to reduce the usage of titles. IMO the people use to understand texts like "inertial.w" or "torque.tau", so my preference is to reduce the usage of legend in Curve where possible. Where curves of the same quantity are ploted in one diagram, something like Plot.title="Angular velocities" could be sufficient.

I will review your PRs regarding "mechnical" examples having abovementioned in mind. Starting probably end of September due to vacations.

tobolar avatar Aug 08 '25 09:08 tobolar

Generally, I would prefer to reduce the usage of titles. IMO the people use to understand texts like "inertial.w" or "torque.tau", so my preference is to reduce the usage of legend in Curve where possible. Where curves of the same quantity are ploted in one diagram, something like Plot.title="Angular velocities" could be sufficient.

I think most of these figures were created before we even had support for captions in System Modeler, which much also have contributed to titles trying to convey too much information. Now that a figure can have captions, I am also strongly in favor of having concise titles (but not to leave empty and for the tool to decide), and then make use of captions whenever this is needed to make the figure speak for itself.

henrikt-ma avatar Aug 11 '25 12:08 henrikt-ma

I will delay the review of this PR until we resolve the discussion in #4674, #4675 and #4676.

christiankral avatar Sep 22 '25 09:09 christiankral