ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard

Remove unreliable signals very close to zero

Open casella opened this issue 1 year ago • 3 comments

These signals only depend on numerical approximations and CSV compare cannot evaluate them reliably because it lacks information about their magnitude (nominal attribute).

casella avatar Jun 18 '24 16:06 casella

Once approved, this should be cherry-picked to maint/v4.1.0 as well.

casella avatar Jun 18 '24 16:06 casella

@HansOlsson the more I think of it the more I see you point. These signals are supposed to be near zero, and if we don't check they may (in principle) stray away.

One could argue that they very likely can't do that without some of the non-zero components changing significantly, but at the end of the day this issue can be really fixed by just adding some sensible absolute tolerance to the CVS-compare tool.

I'll keep this on hold for the time being.

casella avatar Jul 02 '24 20:07 casella

I converted it to a draft PR to reflect the previous comment and avoid accidental merging.

maltelenz avatar Jul 03 '24 06:07 maltelenz