ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard

Published 20 hours ago • verified publisher icon modelica

Update CoupledClutches.mos

Open Harisankar-Allimangalath opened this issue 10 months ago • 5 comments

backport #4350

Harisankar-Allimangalath avatar Mar 28 '24 04:03 Harisankar-Allimangalath

@dietmarw can you please review the changes .

Thankyou

Harisankar-Allimangalath avatar Apr 24 '24 05:04 Harisankar-Allimangalath

There is no need since it only needs 2 approved reviews.

dietmarw avatar Apr 24 '24 05:04 dietmarw

What is missing is which milestone this should go into. Is this meant for 4.1.0 (probably to late now) or for 4.1.1. This is crucial also to mark before a review is triggered.

dietmarw avatar Apr 24 '24 05:04 dietmarw

Hi @dietmarw , Thankyou for the information , I copied the settings , labels from #4350 and kept the milestone blank as it was missing in the original PR . you are right , adding that would also have been better . @HansOlsson @DagBruck can you please merge this .

Thankyou

Harisankar-Allimangalath avatar Apr 24 '24 05:04 Harisankar-Allimangalath

Not having a milestone set is a HUGE mistake. EVERY PR needs to have a milestone otherwise it is impossible to later find out which changes where done for which version. You should go through all PRs (open and closed and also closed issues) without an assigned milestone and assign them appropriately.

dietmarw avatar Apr 24 '24 05:04 dietmarw