ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard

Reintroduce Arrow as a visualization shape

Open tobolar opened this issue 1 year ago • 2 comments

Reintroduce Arrow as a common visualization object, similar to a box or a sphere. In the MultiBody, this PR uses the Arrow now for visualization of axes of coordinate system in

  • MultiBody.Visualizers.FixedFrame
  • MultiBody.World

which simplifies the two models.

To better understand the idea, see also https://github.com/modelica/ModelicaStandardLibrary/issues/3931#issuecomment-1594362054

This PR bases on #4248.

Note: I didn't change DoubleArrow since I consider this being an obsolete model.

tobolar avatar Jan 11 '24 14:01 tobolar

I've realized the usage of Mechanics.MultiBody.Visualizers.Advanced.Arrow inside of Mechanics.MultiBody.World leads to a recursion issue since Arrow itself uses outer world. A solution could be to define Mechanics.MultiBody.Visualizers.Internal.Arrow which do not uses world.

tobolar avatar Jan 11 '24 16:01 tobolar

@tobolar this change could have other side effects that we are not aware of, and potentially break some aspects of the MultiBody library.

I think it would be wiser to postpone this to MSL 4.2.0, so it can be thoroughly tested with multiple tools.

casella avatar Jan 16 '24 22:01 casella