ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard

Do not preserveAspectRatio for terminate-block.

Open HansOlsson opened this issue 2 years ago • 1 comments

The reason is that you want to write an expression and it is natural to adapt the length of the block to the expression, which will give different aspect ratios. This is consistent with the source-block BooleanExpression. Related to #3985

HansOlsson avatar May 12 '22 07:05 HansOlsson

Note that:

  • The block is used in two places in MSL: Modelica.Mechanics.MultiBody.Examples.Systems.RobotR3.Utilities.PathPlanning1 (and 6). Neither of them have the given aspect ratio, - this is a clear indication that preserving the aspect ratio doesn't give the desired result.
  • If the aspect ratio isn't preserved the square in the terminate-symbol will no longer be square (as seen in those models), however, the benefit of more readable text outweighs the minor non-squareness.

HansOlsson avatar May 12 '22 08:05 HansOlsson

@AHaumer and @MartinOtter would you please review fix for this ticket? Please also let us know if additional info or summary would help you expedite the review.

TManikantan avatar Feb 24 '23 08:02 TManikantan