ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard
verified publisher icon modelica

Adds animated level on the icon layer of the OpenTank

Open dietmarw opened this issue 3 years ago • 4 comments

Basically implementing the same feature as already present in Modelica.Fluid.Vessels.OpenTank

dietmarw avatar Feb 23 '22 17:02 dietmarw

Peek 2022-02-23 18-55

dietmarw avatar Feb 23 '22 17:02 dietmarw

@AHaumer and @christiankral Any chance to review this?

dietmarw avatar Jun 14 '22 08:06 dietmarw

OK, as far as I understand the graphic annotations, this looks good. One question, however, before adding my review: Why is preserveAspectRatio=false in the proposal, whereas Modelica.Fluid.Vessels.OpenTank uses preserveAspectRatio=true?

christiankral avatar Jun 15 '22 13:06 christiankral

Why is preserveAspectRatio=false in the proposal, whereas Modelica.Fluid.Vessels.OpenTank uses preserveAspectRatio=true?

The PR removes that annotation and does not set it to false. Default is true.

dietmarw avatar Jun 15 '22 14:06 dietmarw

@AHaumer would you please review fix for this ticket? Please also let us know if additional info or summary would help you expedite the review.

TManikantan avatar Feb 24 '23 09:02 TManikantan

@AHaumer would you please review the fix ?

TManikantan avatar Apr 05 '23 11:04 TManikantan