ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard

Change table to figure tag in User's Guide

Open christiankral opened this issue 6 years ago • 7 comments

Refs #2519

christiankral avatar Jul 11 '19 21:07 christiankral

@HansOlsson

Dymola's internal rendering does not seem to fully support the new variant...

Your are right!

grafik

tobolar avatar Jul 12 '19 11:07 tobolar

This highlights one part that was only part of the old examples - but not stated: the placement of the caption.

Old caption in tables used align="bottom" to indicate that they should be placed beneath the image. That is also part of the examples. However, it is not documented and for figures that instead depend on the order between img and figcaption. I believe that should be made clear if that is the intent; especially since the caption was normally placed before the table-data (and thus has to be moved).

This is fixed in f6f93c11fffa2ac5e51a1a4e9c1820cb1b882fcd.

I also noticed that Dymola's internal rendering does not seem to fully support the new variant; which causes a bit of problem for us.

As the release of the MSL 4.0.0 is due in March 2020, I guess there is sufficient time to fix this display issue in Dymola. @HansOlsson is this a proper approach?

christiankral avatar Jul 12 '19 14:07 christiankral

As the release of the MSL 4.0.0 is due in March 2020

Here's my proposal of the release schedule:

  • January 2020 MSL v4.0.0 Alpha
  • February 2020 MSL v4.0.0 Beta
  • Early March 2020 MSL v4.0.0 RC.1
  • 2020-03-25 MSL v4.0.0 Release

beutlich avatar Jul 20 '19 18:07 beutlich

@HansOlsson Do you think we shall proceed with this PR?

christiankral avatar Oct 19 '19 14:10 christiankral

I'd prefer to wait with merging this PR after https://github.com/modelica/ModelicaSpecification/issues/2395 is resolved. Thus, it only can be merged after MSL v4.0.0 (which will be based on Modelica v3.4)

Similarily, we have no SVGs in the MSL, but need to wait for https://github.com/modelica/ModelicaSpecification/issues/174.

beutlich avatar Oct 19 '19 16:10 beutlich

OK. I understand.

christiankral avatar Oct 20 '19 08:10 christiankral

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 11 '20 14:06 CLAassistant