ModelicaSpecification
ModelicaSpecification copied to clipboard
Removing Modifications (MCP-0009)
Creating the pull request to start discussions
Seems ok to me too. We haven't implemented it in OpenModelica yet, but it looks fairly straight-forward and I don't really see any issues.
Collection of reviews:
- Hans Olsson: "The experience with the proposal is that it is a small addition, easy to implement, and easy to understand. The implementation effort was less than two days - including error cases; and handling the various cases in the GUI. The only minor issue is that some attributes are connected (so breaking start while keeping fixed=true), but the same applies in other cases and a tool can help reduce that problem - and I don't see how to easily fix it." https://github.com/modelica/ModelicaSpecification/pull/3167#pullrequestreview-1107502425_
- Quentin Lambert: "So I can't formally approve the PR because I created it. But it looks good to me."; https://github.com/modelica/ModelicaSpecification/pull/3167#pullrequestreview-966115757_
- Per Öst: "Seems ok to me too. We haven't implemented it in OpenModelica yet, but it looks fairly straight-forward and I don't really see any issues." https://github.com/modelica/ModelicaSpecification/issues/3167#issuecomment-1156573296_
Some remaining issue that seems to be resolved, and as soon as that is confirmed as resolved we can move forward.