ModelicaSpecification
ModelicaSpecification copied to clipboard
Selective Model Extension (with specification text)
Just trying to get MCP/0032 specification ready.
Whether this should replace MCP/0032 or be merged directly is a latter issue. First is this ok-ish @christoff-buerger ?
It seems like the intent is that only components and connections are allowed to be deselected, but I'm not really seeing any rule that forbid other elements (like classes) from being deselected. The semantic rules list components and connections, but that list could be interpreted as just extra rules for those elements.
But other than that minor issue it looks good to me.
It seems like the intent is that only components and connections are allowed to be deselected, but I'm not really seeing any rule that forbid other elements (like classes) from being deselected
Yes. That seems like a minor issue that should be clarified.
It seems like the intent is that only components and connections are allowed to be deselected, but I'm not really seeing any rule that forbid other elements (like classes) from being deselected. The semantic rules list components and connections, but that list could be interpreted as just extra rules for those elements.
Only component and connections can be deselected. As you say yourself, these are the ones listed. The list is exhaustive and normative; it is not non-normative text (everything non-normative is markes as example).
Collection of reviews:
- Gerd Kurzbach "The specification looks good. Last week I did an implementation in SimulationX. During this time there appeared no problems. It turned out that it is really not difficult and a complete implementation can be done in about 2 working days." https://github.com/modelica/ModelicaSpecification/pull/3166#pullrequestreview-1097291110_
- Per Öst "It seems like the intent is that only components and connections are allowed to be deselected, but I'm not really seeing any rule that forbid other elements (like classes) from being deselected. The semantic rules list components and connections, but that list could be interpreted as just extra rules for those elements. But other than that minor issue it looks good to me." https://github.com/modelica/ModelicaSpecification/issues/3166#issuecomment-1158866698_
- Quentin Lambert "This seems good to me.; https://github.com/modelica/ModelicaSpecification/pull/3166#pullrequestreview-966061900_
- Elena Shmoylova: "Looks good over all. Just a minor wording comment." https://github.com/modelica/ModelicaSpecification/pull/3166#pullrequestreview-1099156824
Will move forward as soon as that is resolved.
(Will check that the line didn't get too long and that it built.)