servers icon indicating copy to clipboard operation
servers copied to clipboard

Add line limits and env variable configs

Open olaservo opened this issue 6 months ago • 3 comments

Description

Server Details

  • Server: filesystem
  • Changes to: tools

Motivation and Context

There were some followups needed from this older PR: https://github.com/modelcontextprotocol/servers/pull/1027

How Has This Been Tested?

Will add tests after this jest setup is merged: https://github.com/modelcontextprotocol/servers/pull/1405

Breaking Changes

None

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation update

Checklist

  • [ ] I have read the MCP Protocol Documentation
  • [ ] My changes follows MCP security best practices
  • [ ] I have updated the server's README accordingly
  • [ ] I have tested this with an LLM client
  • [ ] My code follows the repository's style guidelines
  • [ ] New and existing tests pass locally
  • [ ] I have added appropriate error handling
  • [ ] I have documented all environment variables and configuration options

olaservo avatar Jun 16 '25 06:06 olaservo

@claude please add tests that will cover the functionality being added in this PR.

olaservo avatar Aug 17 '25 17:08 olaservo

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

claude[bot] avatar Aug 17 '25 17:08 claude[bot]

@olaservo are you able to try pushing your changes to a branch on the main servers repo, rather than your own repo? Not sure if you have perms, but maybe give it a shot? I think that will allow Claude to respond.

I'm still chasing internally about getting it working on forks - turns out to be a tricky problem security wise.

domdomegg avatar Aug 23 '25 07:08 domdomegg