python-sdk icon indicating copy to clipboard operation
python-sdk copied to clipboard

show_server_info

Open barnuri opened this issue 9 months ago • 8 comments

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation update

Checklist

  • [x] I have read the MCP Documentation
  • [x] My code follows the repository's style guidelines
  • [x] New and existing tests pass locally
  • [x] I have added appropriate error handling
  • [x] I have added or updated documentation as needed

Additional context

barnuri avatar Mar 16 '25 11:03 barnuri

@Kludex can you review ?

barnuri avatar Mar 19 '25 07:03 barnuri

@dsp-ant can you look ?

barnuri avatar Mar 27 '25 07:03 barnuri

I think it's more useful in the stdio case. Since nothing happens when you start the application.

But on the HTTP, it will be a bit noisy...

If it's in debug level then I think it's fine.

Kludex avatar Mar 28 '25 05:03 Kludex

ok i will change to debug

barnuri avatar Mar 28 '25 05:03 barnuri

@Kludex @dsp-ant moved it to helper method and class, I think its very useful, for example in my code when im using sse i will add a route that return this object in some route for example /info (like in rest api have swagger json doc) the idea of it is to have something simple without creating a client that can be easily visible same for using stdio and then i will use the debug log i hope you would like it :)

barnuri avatar Mar 28 '25 11:03 barnuri

@Kludex @dsp-ant moved it to helper method and class, I think its very useful, for example in my code when im using sse i will add a route that return this object in some route for example /info (like in rest api have swagger json doc) the idea of it is to have something simple without creating a client that can be easily visible same for using stdio and then i will use the debug log i hope you would like it :)

reping

barnuri avatar Apr 11 '25 14:04 barnuri

@dsp-ant @Kludex can you tell me what do you think ?

barnuri avatar Apr 21 '25 08:04 barnuri

@ihrpr @jerome3o-anthropic can you review ?

barnuri avatar Apr 23 '25 04:04 barnuri

I am closing this out since we haven't made much progress. I think this is mostly on us for screwing up reviewing this properly. Sorry @barnuri . I think in general we are still interested in the feeature, but mindful that we shouldn't add the underlying types to src/mcp/types.py since that file reflects the official protocol. This is an SDK feature only. If you are interested in redoing this ontop of the current state of the repo, please do so and ping me either via the MCP Contributor discord or on the PR and I will get to it.

Again, I am very sorry that we didn't review this in proper time and made the progress very slow.

dsp-ant avatar Aug 05 '25 14:08 dsp-ant