shipkit icon indicating copy to clipboard operation
shipkit copied to clipboard

Published 20 hours ago • verified publisher icon mockito

Upgrade downstream improvements

Open wwilk opened this issue 7 years ago • 0 comments

Here are a few problems with the current design of version upgrade:

  1. When we update open pull request, we don't update the title of it. Two solutions I can think of:
  • update the title too, it would require another task and GitHub API call
  • use title without version, eg "Shipkit upgraded". Simpler but it would make it harder to investigate history of closed pull requests, I guess.

  1. Merge pull request automatically when all checks passed.

  2. Add validation to UpgradeDependencyPlugin for "dependency" property. All tasks that depend on this property should fail fast and with a meaningful message if it's not provided. #614

  3. Remove UpgradeDependencyExtension from CreatePullRequestTask and ReplaceVersionTask.

wwilk avatar Dec 10 '17 11:12 wwilk