react-native-zip-archive icon indicating copy to clipboard operation
react-native-zip-archive copied to clipboard

Add RNW (windows) support

Open namrog84 opened this issue 5 years ago • 4 comments

A variety of RN packages have started adding windows support via React-Native-Windows

https://github.com/microsoft/react-native-windows

e.g. https://github.com/react-native-community/react-native-video/tree/master/windows

React-Native-Zip-Archive should too. :thumbsup:

namrog84 avatar Sep 14 '20 20:09 namrog84

is there any interest in having this merged/worked on? A few things have changed but there is still a solid need for official support @plrthink I'm working on making the windows version that @namrog84 has worked on (later improved upon by @nejcet) compatible with RN 0.70.3 & RNW 0.70.3 (recently updated the repository to be up to date with mockingbot/master) but I'm probably out of my depth.

https://github.com/Slyther/react-native-zip-archive

EDIT: I see you've mentioned before that you're willing to merge in a PR that's up to date. Would you still be OK with that?

Slyther avatar Oct 26 '22 19:10 Slyther

I had forgotten @namrog84 's comment about native zip/unzip support on Windows. Maybe we can look into whether native support has improved or we could broaden the use of miniz to implement zipping?

Slyther avatar Oct 26 '22 20:10 Slyther

For more context of what we ended up doing for our project. We ended up managing to fully encapsulate all our particular and simple use cases(a few small files) using a RN file manager(modded RNFS) and using jszip. So our need of react-native-zip-archive ended and thus we removed our usage of miniz and other libs.

However, I still think react-native-zip-archive would have benefit for those that need more fully featured scenarios or needed more performance. I will leave that PR open, as we did use that approach for 1-2 years without issues. Feel free to close if no longer relevant. Otherwise I'd be glad to offer any insights or thoughts if needed.

namrog84 avatar Oct 26 '22 23:10 namrog84

Yes, I'm very excited to make this happen.

But I'm not familiar with the things on the Windows, so it would be great if @namrog84 could help review the PR once @Slyther opened.

plrthink avatar Oct 27 '22 03:10 plrthink