Principia icon indicating copy to clipboard operation
Principia copied to clipboard

The error messaging logic in the flight plan is brittle and incompatible with localization

Open eggrobin opened this issue 5 years ago • 0 comments

The logic tries reverse-engineer the issue from the status code and miscellaneous information; now that we can get the message of a status through the interface it may be best to use those. https://github.com/mockingbirdnest/Principia/blob/984a6bc0af1e58e21ccddf5a43a7d58a1c3824a9/ksp_plugin_adapter/flight_planner.cs#L559-L614

As for the localization issue, see the sentence fragments backing this: https://github.com/mockingbirdnest/Principia/blob/984a6bc0af1e58e21ccddf5a43a7d58a1c3824a9/ksp_plugin_adapter/localization/en-us.cfg#L142-L164

eggrobin avatar Mar 11 '21 16:03 eggrobin