Robert Fletcher

Results 220 comments of Robert Fletcher

@sds thanks, we'll try that out. One thing I'm noticing is that if we pass a custom config the performance is significantly slower: ```sh $ HAML_LINT_RUBOCOP_CONF=.rubocop-haml-lint.yml bundle exec rake haml_lint...

I opened an issue on RuboCop about it. It looks like it's re-loading the configuration every time for some reason. Way off topic now, but would it be possible to...

I'm still seeing this issue as well. Heroku locks the bundler version at 2.3.25, so upgrading to the latest isn't an option. I also see the error running the build...

I ran into this as well, but my use case doesn't have a `before_action`: ```rb def destroy ... destroy_step(step, campaign) end private def destroy_step(step, campaign) ... flash[:success] = t('.success') end...

@davidwessman does the shorthand work in places where it wouldn't be treated this way? I haven't tested mailers, but I assume they would behave the same way.

@mscurtescu is the expected result in this case that it should be `nil` instead? How does this impact your workflow?

Similar to [this issue](https://github.com/feedjira/feedjira/issues/494), our dependency on `sax-machine` makes it hard to change this. I'll tinker with that at some point.

@hwo411 thanks for reporting this! On one hand, this seems like an uncommon scenario, though I guess it could be an issue for comment feeds. But it should be a...

@vdias would you mind making a PR to improve the documentation?