mocha icon indicating copy to clipboard operation
mocha copied to clipboard

fix: watching files outside cwd

Open mark-wiemer opened this issue 5 months ago • 3 comments

PR Checklist

  • [x] Addresses an existing open issue: fixes #5355
  • [x] That issue was marked as status: accepting prs (note that I was the one that added that tag!)
  • [x] Steps in CONTRIBUTING.md were taken

Overview

In #5256 we changed the watched path from watchFiles to . (cwd). Nobody commented on this, and it broke this behavior. Reverting that line fixes the reported issue in the provided repro

mark-wiemer avatar Jun 12 '25 02:06 mark-wiemer

Draft until:

  • [ ] tests added
  • [ ] understand why we may have wanted to make the reverted change in the first place (or confident that it was a mistake)

mark-wiemer avatar Jun 12 '25 02:06 mark-wiemer

@mochajs/maintenance-crew would appreciate your insights here, looks like this was a recently-introduced bug but I'm certainly no expert :)

mark-wiemer avatar Jun 12 '25 02:06 mark-wiemer

I'm no expert on this either but it looks sensible as a fix

voxpelli avatar Jun 12 '25 05:06 voxpelli

Closing (at least for now) in favor of #5379

mark-wiemer avatar Jul 12 '25 16:07 mark-wiemer