mocha icon indicating copy to clipboard operation
mocha copied to clipboard

feat: highlight browser failures

Open mark-wiemer opened this issue 1 year ago • 1 comments

PR Checklist

Overview

  • Change pass indicator to accessible color in light mode (dark green)
  • As soon as a test fails, add a red fail indicator and color the "failures" text red
  • As soon as all tests have a result, and none are failures, add a green pass indicator and color the "passes" text green
  • Result indicators for the root suite are the same for the result indicators for individual tests
    • Except result indicator for root suite is only pass/fail, skip for root suite will show pass for simplicity (happy to change)

image

image


image

image

mark-wiemer avatar Oct 10 '24 13:10 mark-wiemer

@JoshuaKGoldberg, ready for review :)

mark-wiemer avatar Oct 11 '24 01:10 mark-wiemer

Thanks @JoshuaKGoldberg, glad I could help. Just curious, is there an ETA for when this might be merged? Would love to see my work deployed (I am a selfish and proud man 😆)

mark-wiemer avatar Oct 26 '24 17:10 mark-wiemer

Haha that resonates with me. This is a UI-only change and the other maintainers haven't had time, let's ship! 🚀

JoshuaKGoldberg avatar Oct 29 '24 18:10 JoshuaKGoldberg